space: Fix clobbering presence data #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmars
force-pushed
the
fix-presence-update
branch
from
4d615aa
to
96d3409
Compare
Before this commit, space.updateProfileData would call presence.update with just the updated profile data, removing the previous and current locations that might be set in the presence data. This commit fixes the issue by introducing an updateSelf function which allows callers to mutate the member retrieved from getSelf and trigger a presence update which maintains unrelated fields within the resulting presence data. Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
lmars
force-pushed
the
fix-presence-update
branch
from
96d3409
to
e05fefe
Compare
|
Superseded by changes in #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
space.updateProfileDatawould callpresence.updatewith just the updated profile data, removing the previous and current locations that might be set in the presence data.This commit fixes the issue by introducing an
updateSelffunction which allows callers to mutate the member retrieved fromgetSelfand trigger a presence update which maintains unrelated fields within the resulting presence data.