Update TypeScript config to strict mode #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artismarti
approved these changes
Aug 7, 2023
dpiatek
force-pushed
the
mmb-178-add-members-namespace
branch
2 times, most recently
from
d4d0013
to
33c5990
Compare
dpiatek
pushed a commit
that referenced
this pull request
Aug 9, 2023
This only until the updates from #103 are merged.
dpiatek
pushed a commit
that referenced
this pull request
Aug 9, 2023
This only until the updates from #103 are merged.
added 8 commits
August 9, 2023 16:56
Update as newer types were incompatible.
This commit changes how we handle updates for presence spaces. An presence update becomes a PresenceMember:
export type PresenceMember = {
data: {
profileUpdate: {
id: string | null;
current: ProfileData;
};
locationUpdate: {
id: string | null;
previous: unknown;
current: unknown;
};
};
} & Omit<Types.PresenceMessage, 'data'>;
Which then gets translated for the developer to a SpaceMember:
export type SpaceMember = {
clientId: string;
connectionId: string;
isConnected: boolean;
profileData: ProfileData;
location: unknown;
lastEvent: {
name: Types.PresenceAction;
timestamp: number;
};
};
data on PresenceMember contains the last update for profileData an location. The current key is the value of these properties on SpaceMember.
profileUpdate and locationUpdate contain an id. This id is set on publish, but only when we are providing new data, not copying already set data.
The handlers check the id to decide if an update should be emitted (it will still be applied, and it should be the same).
GregHolmes
pushed a commit
to GregHolmes/spaces
that referenced
this pull request
Aug 11, 2023
This only until the updates from ably#103 are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the codebase follow strict TypeScript rules.