Add GitHub Actions workflow for CDN uploads #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmars
reviewed
Aug 22, 2023
It's not secret, I just think this was a way to centrally manage the values, and the person who did it first made them secrets rather than variables, and we just stuck with that convention. |
I actually think that person was possibly me, where I did it for convenience in a private repository but I did think that maybe in a public repo it could be considered sensitive... but apparently the definitive answer is that they are not sensitive. |
lmars
approved these changes
Aug 22, 2023
Initially I've added this as a workflow dispatch which requires us to manually do this, but once I've confirmed it works as required we can switch it into `release.yml` to automatically push the new bundle for every new release.
surminus
force-pushed
the
mmb-154-ably-cdn
branch
from
d86a481
to
bb247c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I've added this as a workflow dispatch which requires us to manually do this, but once I've confirmed it works as required we can switch it into
release.ymlto automatically push the new bundle for every new release.Unfortunately to test actions with a workflow dispatch they must be merged into
main.I suspect I also need to add the secret for the account ID (is it actually secret? who knows!), which I'll need to ask sec team to do.