Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'cursorsUpdate' event to 'update' #120

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Change 'cursorsUpdate' event to 'update' #120

merged 1 commit into from
Aug 22, 2023

Conversation

surminus
Copy link
Collaborator

The API states that a namespace should use update for the event name rather than cursorUpdate.

@surminus
Change 'cursorsUpdate' event to 'update'
9d98dd3 
The API states that a namespace should use `update` for the event name
rather than `cursorUpdate`.
@surminus surminus mentioned this pull request Aug 22, 2023
Merged
Srushtika
Srushtika approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Srushtika
Copy link
Member

@ttypic FYI

@surminus surminus merged commit 86253eb into main Aug 22, 2023
5 checks passed
@surminus surminus deleted the laura-cursors-update branch August 22, 2023 15:33
@Srushtika Srushtika mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srushtika Srushtika Srushtika approved these changes

@lmars lmars lmars approved these changes

@artismarti artismarti Awaiting requested review from artismarti

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surminus @Srushtika @lmars