Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMB-275] Update members update event #156

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Sep 4, 2023

This change bring "update" inline with how we describe "update" in the docs - as an events that catches all events, instead of just profile updates.

To accomodate only profile update changes, an updateProfile event was added.

This is based on feedback, where users found that "update" did was inconsistent with other APIs.

@dpiatek dpiatek marked this pull request as ready for review September 4, 2023 12:14
@dpiatek dpiatek force-pushed the mmb-275-update-members-update-event branch from 92b0cc5 to a36a48a Compare September 4, 2023 12:39
@dpiatek dpiatek requested a review from ttypic September 4, 2023 12:40
Dominik Piatek added 2 commits September 4, 2023 13:41
This change bring "update" inline with how we describe "update" in the docs - as an events that catches all events, instead of just profile updates.

To accomodate only profile update changes, an updateProfile event was added.

This is based on feedback, where users found that "update" did was inconsistent with other APIs.
@dpiatek dpiatek force-pushed the mmb-275-update-members-update-event branch from 462b0dd to 3cb64d4 Compare September 4, 2023 12:41
Copy link
Member

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the docs folder and readme, looks great!

Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpiatek dpiatek merged commit a16eef3 into main Sep 4, 2023
5 checks passed
@dpiatek dpiatek deleted the mmb-275-update-members-update-event branch September 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants