refactor: avoid early initialisation of common errors #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaScript stack straces are created upon initialisation of the `Error` object, so when errors are initialised ahead of the time they are thrown, the stack trace will not show the context of where/why the error was thrown.
dpiatek
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript stack straces are created upon initialisation of the
Errorobject, so when errors are initialised ahead of the time they are thrown, the stack trace will not show the context of where/why the error was thrown, only the context of how theErrors.tsmodule was first loaded.We used to do the same thing in ably-js until someone pointed out that they were getting misleading stack traces, see: