Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMB-247] Channel tagging #166

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[MMB-247] Channel tagging #166

merged 2 commits into from
Sep 8, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Sep 8, 2023 •
edited
Loading

  • update cursors channels to a tagged channel
  • update space channel to a suffix, so later can be easily chaged to a tagged channel

https://ably.atlassian.net/browse/MMB-247

lmars
lmars reviewed Sep 8, 2023
View reviewed changes
src/Space.ts Outdated Show resolved Hide resolved
@dpiatek @lmars
Update comment
93fa030 
Co-authored-by: Lewis Marshall <lewis.marshall@ably.com>
@dpiatek dpiatek merged commit 4aead8f into main Sep 8, 2023
5 checks passed
@dpiatek dpiatek deleted the mmb-247-channel-tagging branch September 8, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmars lmars lmars approved these changes

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@Srushtika Srushtika Awaiting requested review from Srushtika

@m-hulbert m-hulbert Awaiting requested review from m-hulbert

@ttypic ttypic Awaiting requested review from ttypic

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpiatek @lmars @SimonWoolf