Fix cursors demo issues #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiatek
force-pushed
the
fix-cursors-demo-issues
branch
2 times, most recently
from
31688aa
to
b5ad1ad
Compare
dpiatek
force-pushed
the
fix-cursors-demo-issues
branch
from
b5ad1ad
to
a495113
Compare
dpiatek
force-pushed
the
fix-cursors-demo-issues
branch
from
a495113
to
39e4e3a
Compare
lawrence-forooghian
approved these changes
Sep 26, 2023
added 2 commits
September 27, 2023 08:57
This simplifies the cursors component and fixes the issue where cursor icons would stay even after a member has left.
dpiatek
force-pushed
the
fix-cursors-demo-issues
branch
from
39e4e3a
to
98794db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursors.setthrowing an error because we call it before a space was entered