Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CDN link #334

Merged
merged 1 commit into from
Sep 25, 2024
Merged

docs: update CDN link #334

merged 1 commit into from
Sep 25, 2024

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Sep 25, 2024

Update broken CDN link

Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but have a question:
Do we know if this is a bug in our CDN deployment script in spaces that it doesn't allow us to lock to 0.4.* version with https://cdn.ably.com/spaces/0.4/iife/index.bundle.js link?
In ably-js it works as expected and link like https://cdn.ably.com/lib/ably.min-2.3.js returns you the latest 2.3.2 version.
Or is it the intended behavior of the cdn deploy script with non stable releases (seeing that spaces is still in 0.*)?
If it's a bug, should create a separate issue for this and fix in the future

@ttypic
Copy link
Collaborator Author

ttypic commented Sep 25, 2024

@VeskeR yes, for ably-js some special logic has been implemented, for spaces and other projects - not

@ttypic ttypic merged commit 9b74209 into main Sep 25, 2024
7 checks passed
@ttypic ttypic deleted the chore-update-cdn branch September 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants