Add unsubscribe function to event listener #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2023 14:44
… in space" This reverts commit 86b08aa.
Peter-Maguire
changed the title
|
@Peter-Maguire could rebase and remove the initial 2 commits here? (I'm assuming you mean to squash the linting issue when merging?) |
dpiatek
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
I think this is suitable to what we have now, although ideally, we'd be able to have an .off method that does not require the developer to keep a reference to the handler, or clean-up.
For the moment, because we want to rethink what kind of event emitter we would like to use, which will impact what can do, I'm happy to approve.
* fix incorrect time dayjs function in status indicator * rename data to profileData to reflect changes in the space library * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.