[MMB-174] Remove named cursors #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-hulbert
requested changes
Jul 21, 2023
docs/usage.md
Outdated
| ``` | ||
|
|
||
| `set` takes an object with 2 properties. `position` is an object with 2 required properties, `x` and `y`. These represent the position of the cursor on a 2D plane. A second property, `data` can passed. This is an object of any shape and is meant for data associated with the cursor movement (like drag or hover calculation results): |
There was a problem hiding this comment.
Suggest the same wording update as in class-definitions.
artismarti
approved these changes
Jul 21, 2023
dpiatek
force-pushed
the
mmb-174-remove-named-cursors
branch
from
77ac296
to
6cdc9ce
Compare
dpiatek
force-pushed
the
mmb-174-remove-named-cursors
branch
from
6cdc9ce
to
f541cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided this feature. In it's current implementation is causing much more confusion than it is solving problems.
This removes completely the idea of "named cursors" i.e. name-spaced event emitters.