Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMB-175] Only initialise cursors channel when .on or .set are called #93

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Jul 25, 2023

This changes the behaviour to only initialise a channel when a developer starts listening to cursor events or sets an update.

This changes the behaviour to only initilize a channel when a developer starts listening to cursor events or sets an update.
Copy link

@artismarti artismarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
🐑

Does the Readme/docs need updating?

@dpiatek
Copy link
Contributor Author

dpiatek commented Jul 26, 2023

lgtm 🐑

Does the Readme/docs need updating?

We don't really have a section on internal usage of Ably so not at this point I think (but definitely for preview release)

@dpiatek dpiatek merged commit 1d00dd5 into main Jul 26, 2023
@dpiatek dpiatek deleted the mmb-175-only-initialize-cursors-on-set-or-subscribe branch July 26, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants