Updated message spec and related endpoints #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sacOO7
commented
Jan 21, 2025
•
sacOO7
commented
- Updated message spec and related endpoints
- Related ably-java PR [ECO-5193] Support message edits and deletes ably-java#1059
sacOO7
force-pushed
the
fix/operation-struct
branch
from
1d76f98 to
9b04985
Compare
sacOO7
changed the title
This was referenced Jan 22, 2025
sacOO7
force-pushed
the
fix/operation-struct
branch
from
a948cc6 to
a5baa77
Compare
sacOO7
changed the title
sacOO7
force-pushed
the
fix/operation-struct
branch
from
cc5a3dc to
19d3a9d
Compare
AndyTWF
reviewed
Feb 13, 2025
| @@ -580,7 +574,7 @@ h3(#rest-updating-messages). Updating Messages | |||
| h4(#rest-updating-messages-request). Request | |||
|
|
|||
| Below is the full REST payload format for the endpoint. The @description@, @headers@ and both @metadata@ keys are optional. | |||
|
|
|||
| Note that outer @metadata@ is of type map<string, string>. | |||
There was a problem hiding this comment.
Suggested change
| Note that outer @metadata@ is of type map<string, string>. | |
| Note that the root level @metadata@ field is of type map<string, string>. |
| @@ -518,7 +512,7 @@ h4(#rest-sending-messages-request-v1). Corresponding Realtime Event V1 @(depreca | |||
| h4(#rest-sending-messages-request-v2). Request V2 | |||
|
|
|||
| Below is the full REST payload format for the V2 endpoint. The @metadata@ and @headers@ keys are optional. | |||
|
|
|||
| Note that @metadata@ is of type map<string, any> or jsonObject. | |||
There was a problem hiding this comment.
We probably don't need to specify jsonObject here - map<string, any> covers everything?
| "extras": { | ||
| "headers": { | ||
| "baz": "qux" | ||
| }, | ||
| } | ||
| "createdAt": 1726232498871, |
There was a problem hiding this comment.
The timestamp here should match that in the serial.
| "extras": { | ||
| "headers": { | ||
| "baz": "qux" | ||
| } | ||
| } | ||
| "serial": "01726232498871-001@abcdefghij:001", | ||
| "version": "01726585978590-001@abcdefghij:001" | ||
| "serial": "01726585978590-001@abcdefghij:001", |
There was a problem hiding this comment.
The createdAt should match the timestamp in the serial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.