Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api_key): recent links path #192

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

guspan-tanadi
Copy link
Contributor

@guspan-tanadi guspan-tanadi commented Feb 4, 2025

Summary by CodeRabbit

  • Documentation
    • Updated the guidance reference for release procedures to emphasize best practices.
    • Revised the API key documentation by updating the capabilities reference link and correcting a formatting issue in an example configuration.

Copy link

coderabbitai bot commented Feb 4, 2025

Warning

Rate limit exceeded

@guspan-tanadi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd0b33 and ae29d46.

📒 Files selected for processing (2)
  • CONTRIBUTING.md (1 hunks)
  • docs/resources/api_key.md (3 hunks)

Walkthrough

This pull request updates documentation links to reflect current best practices. In CONTRIBUTING.md, the release guidance link has been updated from an SDK-specific URL to one emphasizing best practices. In docs/resources/api_key.md, the link for the capabilities field has been changed to a more streamlined URL and a missing comma in an example has been corrected. No changes have been made to exported or public entities.

Changes

File Change Summary
CONTRIBUTING.md Updated the release process link from /sdk/releases.md to /best-practices/releases.md.
docs/resources/api_key.md Replaced the capabilities link from https://ably.com/docs/core-features/authentication#capabilities-explained to https://ably.com/docs/auth/capabilities and fixed a missing comma in an example.

Suggested reviewers

  • graham-russell

Poem

I'm a rabbit, hopping through the change,
New links bloom in docs, rearranged.
A tweak here, a fix there,
Leaping forward with utmost care.
In digital fields, I hop with glee,
Celebrating updates with nibbles of ASCII: (_/).


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CONTRIBUTING.md (1)

26-26: Updated Release Process Link & Minor Language Suggestion
The release process section now references the updated link (https://github.com/ably/engineering/blob/main/best-practices/releases.md), which aligns with the new best practices emphasis. Additionally, consider adding a definite article (e.g., "the Terraform provider") for clarity.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~26-~26: You might be missing the article “a” here.
Context: ... release N.B. Releasing and publishing Terraform provider follows a process that is diff...

(AI_EN_LECTOR_MISSING_DETERMINER_A)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e21cbbe and a789c1c.

📒 Files selected for processing (2)
  • CONTRIBUTING.md (1 hunks)
  • docs/resources/api_key.md (2 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md

[uncategorized] ~26-~26: You might be missing the article “a” here.
Context: ... release N.B. Releasing and publishing Terraform provider follows a process that is diff...

(AI_EN_LECTOR_MISSING_DETERMINER_A)

🔇 Additional comments (2)
docs/resources/api_key.md (2)

33-33: Updated Capabilities Documentation Link
The link for the capabilities field has been updated to point to the new streamlined URL (https://ably.com/docs/auth/capabilities), ensuring users are directed to the current documentation.


15-25: Verify Terraform Example Syntax
The AI summary notes that a missing comma in the example usage has been corrected. Please double-check that the syntax in the Terraform example (especially the separation of map entries) now conforms to HCL best practices.

docs(contributing): current links
style(resources/api_key): capabilities format
Copy link
Contributor

@surminus surminus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@surminus surminus merged commit f9145c5 into ably:main Feb 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants