-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Use new license key undetected-license
#3021
Comments
@AyanSinhaMahapatra thanks for articulating this issue. As a solution, I would prefer something a bit different, and would like to suggest: custom-license the word "custom" communicates here that yes, this thing really is different and might possibly be a very specific one-time-only thing, but the word "undetected" suggests (unfairly) that there might be a limitation of the license detection process, even though we are likely looking at totally unique license terms. So better not to use that I think. |
Another candidate key could be making it clear that the license text has never been formalized as a standard text with its own name and version. |
@AyanSinhaMahapatra and @pombredanne After further reflection on this topic, I think I prefer unpublished-license |
one final refinement: unpublished-license |
@DennisClark I kinda prefer the |
@pombredanne OK, I can go with |
here we are: custom-license |
It seems that this use case is for license text that we detect as license text but cannot match to an existing license in the SC LicenseDB. (I am assuming that this is not for the case where we a reference to a license but cannot find the corresponding license text). So this seems to be a transitory license identifier where we would often add the license to LicenseDB sooner that later. |
my problem with |
Since we do not have the license text in LicenseDB at the time of running ScanCode "unmatched" seems most descriptive of the situation. If we research and find some standard license text that we add to LicenseDB then this text will have a match in LicenseDB in the future. If/until then this is a placeholder license key for use during scanning. |
We need to discuss this issue in context of the analysis provided already in this issue: where multiple "unstated" licenses are identified with proposed descriptions, which do not yet exist in the licensedb. If we are going to create yet another "un-" license we also need to revisit those others. |
Update the notes for license data files with `unknown` license keys with text authored by @DennisClark Reference: #3021 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Update the notes for license data files with `unknown` license keys with text authored by @DennisClark. See also: #3021 Reference: #2827 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@DennisClark thanks! So the key thing to do is use the excellent definitions you provided in the XLSX of #3021 (comment) and add them to the notes of the license here to remove any ambiguity. For the rare case where there is no license, we can create a |
Update the notes for license data files with `unknown` license keys with text authored by @DennisClark. See also: #3021 Reference: #2827 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
We have some discussion here wrt
unknown
licenses and how in some cases it could be confusing.In license detection there are a few unknown cases: (which are more persistent and will be possibly)
Some part of the solution is:
license_clues
seperately [WIP]But there still remains the confusion as
unknown
might meanlicenses we don't know about
when it actually meanslicenses that weren't detected by scancode
.So the new license-key being proposed is
undetected-license
.It seems important in the context of case 3 (We know there is a license but we cannot detect any), but could also be a replacement for
unknown-license
?@DennisClark @pombredanne @mjherzog what's your opinion on this?
The text was updated successfully, but these errors were encountered: