Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScanCode incorrectly identifies BSD-3-Clause text as proprietary license #3039

Closed
richardfontana opened this issue Aug 4, 2022 · 3 comments
Closed

ScanCode incorrectly identifies BSD-3-Clause text as proprietary license #3039

richardfontana opened this issue Aug 4, 2022 · 3 comments
Labels
bug

Comments

@richardfontana
Copy link

richardfontana commented Aug 4, 2022 •
edited
Loading

Description

I ran ScanCode 31.0.0rc1 on the Fedora source package for webkit2gtk3-2.36.5. The license text in one file, which appears to be identical or substantially identical to this Webkit source file:
https://github.com/WebKit/WebKit/blob/main/Source/cmake/DetectSSE2.cmake
was incorrectly identified as "proprietary-license" by ScanCode, with the score 90.99, for reasons that are unclear to me.
The "matched-rule" is "proprietary-license_501.RULE".

System configuration

  • What OS are you running on? (Windows/MacOS/Linux) Linux
  • What version of scancode-toolkit was used to generate the scan file? 31.0.0rc1
  • What installation method was used to install/run scancode? (pip/source download/other)
    I used the Linux release archive for the stated version of scancode-toolkit.
@pombredanne
Copy link
Member

@richardfontana Thank you ++ for the report!

pombredanne added a commit that referenced this issue Aug 4, 2022
@pombredanne
Report proprietary license if key phrase #3039
38eacdc 
This key phrase should be present
"Every use of the source code or binary form of the software should
acknowledge the publication."

Reported-by: Richard Fontana <rfontana@redhat.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

See #3041 for a likely fix

pombredanne added a commit that referenced this issue Aug 4, 2022
@pombredanne
Merge pull request #3041 from nexB/3039-bsd-not-proprietary-license
ffc47b1 
Report proprietary license only if key phrase present
 #3039
@pombredanne
Copy link
Member

@richardfontana this fix works and has been merged and will be in the next release.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @richardfontana