Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the POM handler for dependency and its sub elements #529

Closed
licodeli opened this issue Mar 2, 2017 · 1 comment
Closed

Refine the POM handler for dependency and its sub elements #529

licodeli opened this issue Mar 2, 2017 · 1 comment

Comments

@licodeli
Copy link
Contributor

licodeli commented Mar 2, 2017

We currently have a line structure to get dependency element and its sub elements. with https://github.com/sassoftware/pymaven and in a maven2.py script? I think this would be much better to get actual deps.

licodeli pushed a commit that referenced this issue Mar 13, 2017
licodeli pushed a commit that referenced this issue Mar 21, 2017
pombredanne pushed a commit that referenced this issue Jun 8, 2017
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne pushed a commit that referenced this issue Jun 8, 2017
 * Implement sub class of Pymaven's Pom class with simple test case
 * Add POM dependency in maven.py with test case
 * Update test cases accordingly

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 8, 2017
 * also simplify data by removing maven_ and component_ prefixes
 * made most maven-related tests data-driven

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 12, 2017
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jun 12, 2017
 * Use a patched subclass of pymaven with enhanced properties resolution
   and extract extra attributes that can serialize to a mapping
 * Update maven test expectations accordingly adding new tests for
   Package creation

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne pushed a commit that referenced this issue Jun 13, 2017
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne pushed a commit that referenced this issue Jun 13, 2017
 * Use pymaven throughout for Maven POM parsing including
   collecting depdenencies
 * Use a patched subclass of pymaven with enhanced properties resolution
   and extract extra attributes that can serialize to a mapping
 * Update maven test expectations accordingly adding new tests for
   Package creation
 * made most maven-related tests data-driven and using plain JSON files

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

This is merged in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants