Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License improvement winter 2022 #2828

Merged
merged 63 commits into from
Feb 14, 2022
Merged

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Feb 1, 2022

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #2819
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the license-improvement-winter-2022 branch from b50831b to d40c65f Compare February 1, 2022 21:32
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: DennisClark @DennisClark
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
x11-xconsortium_veillard was using an underscore which is not SPDX
friendly and is now deprecated. x11-xconsortium-veillard is the new
key

Reference: #2813
Reported-by: Frank Viernau <frank.viernau@here.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Keeping these under 50 characters is a sane thing to do.
Otherwise DBs that have a license key with 50 chars are not super happy.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Thank-you-to: Steve Winslow <steve@swinslow.net> @swinslow
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We now have a named license for this

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Keeping these under 50 characters is a sane thing to do.
Otherwise DBs that have a license key field with 50 chars are not super
happy.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Add new language attribute to a Rule, deafulting to English.

Use proper language tags and SPDX ids for licenses that were kept back.

Reference: #139
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Add language attributes to rules

Move all non-english licenses to the main directory

Fix duplicates rules and licenses

Add new command line option to index with non-english licenses. This
is experimental.

Add check for long SPDX license keys

Reference: #139
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Remove all license cache code checking and validation.
This is a complex and overengineered feature that is only useful for
developers. They can run the --reindex-licenses instead as needed.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
With this new include_ignorables argument, License.to_dict() can
optionally skip ignrable_* attributes.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
With this new include_text argument, License.to_dict() can
optionally include the full license text

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
The new --licenses-reference option adds a new "licenses_reference" top
level attribute to a scan seen in the JSON and YAML attribute. This
contains all the license details.

Also bump the WIP version.

Reference: #1697
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Align with the latest license updates.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Check the correct checksum when no rebuild is requested

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Align with the latest license updates.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #139
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the license-improvement-winter-2022 branch from 646b260 to 4298481 Compare February 10, 2022 23:07
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use better text formatting and remove extra non-text comments

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is a batch of misc.  rules from actual motices or references seen
in the wild.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is marked as expected failure for now until we have proper ways to
combine multiple detections.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
It already exists in the main branch

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
By checking that we have a proper public suffix domain, we avoid many
junk emails.

Reference: #2810
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member Author

All green now... so merging!

@pombredanne pombredanne merged commit 24aae22 into develop Feb 14, 2022
@pombredanne pombredanne deleted the license-improvement-winter-2022 branch February 14, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant