Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for parsing private classifier #3989

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

VarshaUN
Copy link

Fixes #3968

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Varsha U N varshaun58@gmail.com

@VarshaUN VarshaUN force-pushed the support-python-private-package branch from ff1685e to f3511cf Compare November 17, 2024 15:24
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VarshaUN Thanks++

Please always run subset of tests where you have made changes locally and look for test failures. And then also look for test failures in the CI and fix any issues present there too.

@@ -339,6 +339,12 @@ def test_parse_pyproject_toml_standard_lc0(self):
expected_loc = self.get_test_loc('pypi/pyproject-toml/standard/lc0-pyproject.toml-expected.json')
self.check_packages_data(package, expected_loc, regen=REGEN_TEST_FIXTURES)

def test_parse_pyproject_toml_private_package(self):
test_file = self.get_test_loc('pypi/pyproject-toml/private/private_package/pyproject.toml')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added a test but no test file, so this is failing with an OSError, no file found. Please add the corresponding test and expected files too. See https://scancode-toolkit.readthedocs.io/en/stable/contribute/contrib_dev.html#running-tests on how to regen files selectively.

src/packagedcode/pypi.py Outdated Show resolved Hide resolved
@VarshaUN VarshaUN force-pushed the support-python-private-package branch from 36af28a to 0a92f7f Compare December 1, 2024 10:02
…N <varshaun58@gmail.com>

Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
@VarshaUN VarshaUN force-pushed the support-python-private-package branch from 52ef305 to 25f5adb Compare December 23, 2024 16:44
@VarshaUN
Copy link
Author

@AyanSinhaMahapatra I have added every required files now. Please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python private packages
2 participants