Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect versions in GithubDataSource CVE #1399

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix incorrect versions in GithubDataSource CVE #1399

merged 1 commit into from
Jan 22, 2024

Conversation

shravankshenoy
Copy link
Contributor

@shravankshenoy shravankshenoy commented Jan 22, 2024 •
edited
Loading

Fixes #1398

Changes made :

  • Patched code in datasource_advisory_from_cve function in GithubDataSource so that correct versions are displayed

@shravankshenoy
Fix wrong versions error in GithubDataSource
6951513 
Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>
@shravankshenoy shravankshenoy changed the title Fix wrong versions error in GithubDataSource CVE Fix display of incorrect versions in GithubDataSource CVE Jan 22, 2024
@shravankshenoy shravankshenoy mentioned this pull request Jan 22, 2024
Closed
keshav-space
keshav-space approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @shravankshenoy
Thanks ++

@keshav-space keshav-space added the VulnTotal Tool for cross-validating vulnerability label Jan 22, 2024
@keshav-space keshav-space changed the title Fix display of incorrect versions in GithubDataSource CVE Fix incorrect versions in GithubDataSource CVE Jan 22, 2024
@keshav-space keshav-space merged commit 1fc186c into aboutcode-org:main Jan 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshav-space keshav-space keshav-space approved these changes

Assignees
No one assigned
Labels
VulnTotal Tool for cross-validating vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in GithubDataSource CVE in Vulntotal
2 participants
@shravankshenoy @keshav-space