Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set StatusCode to NoContent if Response.Body has been written. #21785

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

@maliming maliming added this to the 9.0-patch-final milestone Jan 2, 2025
@maliming maliming requested a review from EngincanV January 2, 2025 03:04
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (rel-9.0@71e3446). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...Core/Mvc/Response/NoContentTestController_Tests.cs 0.00% 4 Missing ⚠️
...spNetCore/Mvc/Response/AbpNoContentActionFilter.cs 0.00% 2 Missing and 1 partial ⚠️
...AspNetCore/Mvc/Response/NoContentTestController.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             rel-9.0   #21785   +/-   ##
==========================================
  Coverage           ?   51.83%           
==========================================
  Files              ?     3174           
  Lines              ?   101803           
  Branches           ?     7712           
==========================================
  Hits               ?    52770           
  Misses             ?    47415           
  Partials           ?     1618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV merged commit ffaefd2 into rel-9.0 Jan 2, 2025
5 checks passed
@EngincanV EngincanV deleted the AbpNoContentActionFilter branch January 2, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants