Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): Show details for import error #338

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

abrain
Copy link
Owner

@abrain abrain commented Sep 26, 2024

If wp_insert_post returns additional details in the WP_Error object, show them to the user. Also let the user know how many imports were successful before the error.

@abrain abrain self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 25.67%. Comparing base (9ca06ab) to head (0140a1e).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/Import/Helper.php 0.00% 5 Missing ⚠️
src/Import/Tool.php 0.00% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #338      +/-   ##
=============================================
+ Coverage      25.64%   25.67%   +0.02%     
- Complexity      1607     1610       +3     
=============================================
  Files             81       82       +1     
  Lines           6223     6236      +13     
=============================================
+ Hits            1596     1601       +5     
- Misses          4627     4635       +8     
Flag Coverage Δ
integration 11.31% <0.00%> (-0.03%) ⬇️
unit 15.60% <33.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abrain abrain merged commit 0f79f16 into develop Sep 27, 2024
6 of 8 checks passed
@abrain abrain deleted the import-error-details branch October 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant