skip_dir deletes remote data #2909
-
The docs:
I take that to mean the client will do nothing with any directory matching a skip_dir entry. Instead what I found is that if the directory does not exist locally, it deletes a matching remote directory. Maybe the intent of the option needs minor clarification in the docs. My intent was to skip a remote directory. If it is meant to skip only local directories from syncing to the remote OneDrive/SharePoint, that is not stated clearly in the docs. I do see a note that it is a 'Client Side Filtering Rule', but I did not understand that to mean one-directional behaviour. Furthermore, even if the user's intent was to skip syncing a local directory, if there is a typo in the path and it happens to match a remote directory, the remote directory will be deleted. This is, in my humble opinion, a bug, because it is unexpected behaviour for an option named "skip", which implies no action. I was able to achieve the desired result of skipping a remote directory with an exclude entry in the sync_list. It seems this is the intended avenue. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 3 replies
-
The application option operates as intended - it skips the directories and does not delete them. What you are articulating if true would be an application bug, that, after ~350 different use cases which includes this option - and 9+ months of testing before v2.5.0 was released - is either a regression or a serious bug that has slipped through the cracks somehow. Please raise a bug, with all correct evidence for your use of 'skip_dir' so this can be evaluated and verified. |
Beta Was this translation helpful? Give feedback.
-
@dalemartin
And the directory is correctly excluded and not deleted online. Please provide way more details and/or raise a bug with all details + create a verbose debug log as per: https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support |
Beta Was this translation helpful? Give feedback.
-
As a general side note, I noticed something else while trying to reproduce the deletion behaviour: For example, adding a file to the directory
There are these competing log messages
...and the behaviour is that the file is actually uploaded. |
Beta Was this translation helpful? Give feedback.
-
All Client Side Filtering rules follow this process: Checking 'sync_list' comes after all others - so either the path is not being correctly calculated for 'skip_dir' exclusion, or there is no match. |
Beta Was this translation helpful? Give feedback.
The application option operates as intended - it skips the directories and does not delete them.
What you are articulating if true would be an application bug, that, after ~350 different use cases which includes this option - and 9+ months of testing before v2.5.0 was released - is either a regression or a serious bug that has slipped through the cracks somehow.
Please raise a bug, with all correct evidence for your use of 'skip_dir' so this can be evaluated and verified.