Bug: Local files are not safely backed up (Another #2616 case)

[JC-comp]

Describe the bug

Local files should be safely backed up when the item is not in sync locally to prevent data loss.

Operating System Details

skipped

Client Installation Method

From Source

OneDrive Account Type

Personal

What is your OneDrive Application Version

v2.5.0-alpha-5 GitHub version: v2.4.25-64-g1630ae3

What is your OneDrive Application Configuration

skipped

What is your 'curl' version

skipped

Where is your 'sync_dir' located

Local

What are all your system 'mount points'

skipped

What are all your local file system partition types

skipped

How do you use 'onedrive'

skipped

Steps to reproduce the behaviour

$ touch 1
$ onedrive --sync
$ echo "123" > 1
// delete 1 online
$ onedrive --sync
// file is directly deleted locally

Complete Verbose Log Output

Reading configuration file: /home/alan/.config/onedrive/config
Configuration file successfully loaded
Using IPv4 and IPv6 (if configured) for all network operations
Configuring Global Azure AD Endpoints
Fetching items from the OneDrive API for Drive ID: af2b5e52bea96776 ..
No additional changes or items that can be applied were discovered while processing the data received from Microsoft OneDrive
Trying to delete file 1
Deleting file 1
Performing a database consistency and integrity check on locally stored data .
Scanning the local file system '~/OneDrive' for new data to upload .
Performing a last examination of the most recent online data within Microsoft OneDrive to complete the reconciliation process
Fetching items from the OneDrive API for Drive ID: af2b5e52bea96776 .
No additional changes or items that can be applied were discovered while processing the data received from Microsoft OneDrive

Sync with Microsoft OneDrive is complete

Screenshots

No response

Other Log Information or Details

No response

Additional context

No response

[abraunegg]

Fixed via 1be74fc

Evidence:

Reading configuration file: /home/alex/.config/onedrive/config
Configuration file successfully loaded
Using 'user' configuration path for application state data: /home/alex/.config/onedrive

ERROR: Unable to create /var/log/onedrive
ERROR: Please manually create '/var/log/onedrive' and set appropriate permissions to allow write access for your user to this location.
ERROR: The requested client activity log will instead be located in your users home directory

Using the following path to store the runtime application log: /home/alex
Using IPv4 and IPv6 (if configured) for all network operations
Checking Application Version ...
Attempting to initialise the OneDrive API ...
Configuring Global Azure AD Endpoints
The OneDrive API was initialised successfully
Opening the item database ...
Application Version:  v2.5.0-alpha-5 GitHub version: v2.4.25-64-g1630ae3
Account Type:         business
Default Drive ID:     b!bO8V7s9SSk6r7mWHpIjURotN33W1W2tEv3OXV_oFIdQimEdOHR-1So7CqeT1MfHA
Default Root ID:      01WIXGO5V6Y2GOVW7725BZO354PWSELRRZ
Remaining Free Space: 1023.52 GB (1098994334824 bytes)
Sync Engine Initialised with new Onedrive API instance
All application operations will be performed in the configured local 'sync_dir' directory: /home/alex/OneDrive
Fetching /delta response from the OneDrive API for Drive ID: b!bO8V7s9SSk6r7mWHpIjURotN33W1W2tEv3OXV_oFIdQimEdOHR-1So7CqeT1MfHA
Processing API Response Bundle: 1 - Quantity of 'changes|items' in this bundle to process: 2
Local file time discrepancy detected: ./1
This local file has a different modified time 2024-Feb-11 22:41:45Z (UTC) when compared to online modified time 2024-Feb-11 22:41:25Z (UTC)
The local file has a different hash when compared to online file hash
The local item is out-of-sync with OneDrive, renaming to preserve existing file and prevent local data loss: ./1 -> ./1-onedrive-client-dev
Finished processing /delta JSON response from the OneDrive API
No additional changes or items that can be applied were discovered while processing the data received from Microsoft OneDrive
Performing a database consistency and integrity check on locally stored data
Processing DB entries for this Drive ID: b!bO8V7s9SSk6r7mWHpIjURotN33W1W2tEv3OXV_oFIdQimEdOHR-1So7CqeT1MfHA
Processing ~/OneDrive
The directory has not changed
Processing α
The directory has not changed
...

[abraunegg]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.