Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: file sync (upload/download/delete) notifications #2760

Closed
rubiksdot opened this issue Jul 28, 2024 · 8 comments
Closed

Feature Request: file sync (upload/download/delete) notifications #2760

rubiksdot opened this issue Jul 28, 2024 · 8 comments
Labels
Feature Request Feature Request | Enhancement Request Implemented
Milestone

Comments

@rubiksdot
Copy link

rubiksdot commented Jul 28, 2024

Is your feature request related to a problem? Please describe.

Currently it is not possible to see if a sync (file upload/download/delete) has happened when onedrive is running as a service in the background.

Describe the solution you'd like

I would like to see if files got uploaded/downloaded or deleted (on either side). This would give some comfort in knowing, for eg, when to turn off the laptop or to tell someone to look on onedrive as the file should be there.

If the file is big enough it'd be nice to get a start/finish notification.

Describe alternatives you've considered

Manually checking but, well, that's a pain in the butt. I should be able to get my computer to indicate what's happening.

Additional context

Currently running 2.4.25 on Debian Bookworm.

@rubiksdot rubiksdot added the Feature Request Feature Request | Enhancement Request label Jul 28, 2024
@abraunegg
Copy link
Owner

@rubiksdot
GUI events and notifications for these events are already available.

Have you enabled them ?

@rubiksdot
Copy link
Author

Oooh. My apologies. How? I checked the man page but I didn't spot anything.

@abraunegg
Copy link
Owner

Please read all documentation - not just the man page

@rubiksdot
Copy link
Author

Ok. I tried. I thought it was min_notify_changes but setting that to 1 did nothing and I tried both syncing to one drive and from it.

I looked at the code and maybe this is the wrong place but

if (!downloadFailed) {
			writeln("done.");
			log.fileOnly("Downloading file ", path, " ... done.");
		} else {
			writeln("failed!");
			log.fileOnly("Downloading file ", path, " ... failed!");
		}

does not appear to indicate that the functionality is there.

I do get notifications of onedrive starting up and all but that's about it.

Honestly, am I being a bit thick/blind here or is the functionality not there and we're talking past each other?

@abraunegg
Copy link
Owner

@rubiksdot
So we are talking a number of things:

  • claim that it is not possible to see when file actions are done
    • This is possible via enabling logging and parsing the log file
  • notifying via the GUI of those actions
    • the code in v2.4.x lacks this - correct, however my focus has been v2.5.x over the last 18 months - sorry for the misdirect

@rubiksdot
Copy link
Author

All good. Glad it got cleared up in the end. :) Also, understand that v2.5 would take priority. :)

@abraunegg abraunegg added this to the v2.5.x milestone Aug 21, 2024
@abraunegg abraunegg modified the milestones: v2.5.x, v2.5.0 Sep 2, 2024
abraunegg added a commit that referenced this issue Sep 2, 2024
* Implement Feature Request #2760 by adding config option 'notify_file_actions' to notify via the GUI successful actions.
@abraunegg
Copy link
Owner

@abraunegg
Copy link
Owner

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request Feature Request | Enhancement Request Implemented
Projects
None yet
Development

No branches or pull requests

2 participants