Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'nextLink' value if present when searching for specific SharePoint site names #1329

Merged
merged 9 commits into from
Mar 12, 2021
Merged

Use 'nextLink' value if present when searching for specific SharePoint site names #1329

merged 9 commits into from
Mar 12, 2021

Conversation

abraunegg
Copy link
Owner

  • Use 'nextLink' value if present when searching for specific SharePoint site names

@abraunegg
Use 'nextLink' value if present when searching for specific SharePoi…
95d87c3 
…nt site names

* Use 'nextLink' value if present when searching for specific SharePoint site names
@abraunegg abraunegg added this to the v2.4.11 milestone Mar 9, 2021
@abraunegg abraunegg linked an issue Mar 9, 2021 that may be closed by this pull request
cannot get drive-id due to rest-api limit #1324
Closed
3 tasks
@abraunegg
Merge branch 'master' into fix-issue-1324
125f2b9
@abraunegg
Update sync.d
5d28b5b 
* Add more details as to why a particular site it not able to be matched
@abraunegg
Update sync.d
5ef6bee 
remove only display if not matched, as we might be searching for this site but the name also matches another which previously matches
@abraunegg
Update sync.d
5f8f9fe 
Update error messaging
@abraunegg
Update sync.d
10a436f 
* Update message if 'name' is also restricted
@abraunegg
Update sync.d
1cff322 
* Update language
@abraunegg
Merge branch 'master' into fix-issue-1324
9d21089
@abraunegg abraunegg requested a review from norbusan March 12, 2021 03:08
@abraunegg
Copy link
Owner Author

@norbusan
User confirmed the code fix worked: #1324 (comment)

However another issue popped up, unsure why, but no confirmation re the updated code.

@abraunegg
Update README.md
d9e290d 
* Fix readme by removing '?'
norbusan
norbusan approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part about nextlink looks reasonable, and then there is the rest about retrial etc that seems to me unrelated, but well, retrying makes sense. I cannot test it in actual surroundings, though.

@abraunegg abraunegg merged commit b8717fb into master Mar 12, 2021
@abraunegg abraunegg deleted the fix-issue-1324 branch March 12, 2021 18:11
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@norbusan norbusan norbusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.11
Development

Successfully merging this pull request may close these issues.

cannot get drive-id due to rest-api limit
2 participants
@abraunegg @norbusan