Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneDrive Personal Drive ID and Remote Drive ID length check #3081

Closed
wants to merge 7 commits into from

Conversation

abraunegg
Copy link
Owner

@abraunegg abraunegg commented Jan 18, 2025

  • Add a check to ensure that OneDrive Personal Drive ID and Remote Drive ID values are 16 characters, padded by leading zeros if the provided JSON data has dropped these leading zeros
  • If OneDrive Personal Account, validate all use of 'onedriveJSONItem["parentReference"]["driveId"].str' within application to ensure consistency in use and application

* Add further checks based on PR #3075
@abraunegg abraunegg changed the title Add further checks based on PR #3075 Add OneDrive Personal Drive ID and Remote Drive ID length check Jan 19, 2025
@abraunegg abraunegg added this to the v2.5.4 milestone Jan 19, 2025
@abraunegg abraunegg linked an issue Jan 19, 2025 that may be closed by this pull request
* Debug logging and DB analysis shows that the Graph API for these 15 character elements when changed to 16 character elements all need to be lowercase to be consistent with other application API responses where 16 character driveId values are provided
* Ensure that when a Personal Account driveId is checked, it is always returned as lower case. Evidence has show that the Graph API is inconsistent with parentReference object when value starts with digits.
* Add further driveId check when updating Shared Folder DB Tie record entry with correct values
* Add further checks on 15|16 character driveId and ensuring is lower case
@abraunegg
Copy link
Owner Author

Closing this PR due to concerns with approach

@abraunegg abraunegg closed this Jan 24, 2025
@abraunegg abraunegg removed this from the v2.5.4 milestone Jan 24, 2025
@abraunegg abraunegg deleted the fix-issue-3072v3 branch January 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant