Resolve client 'hang' when attempting to sync a Unix pipe file

[abraunegg]

• Resolve client 'hang' when attempting to sync a Unix pipe file

[abraunegg]

Client filesystem:

total 8
drwxrwxr-x.  2 alex alex  121 Jul  7 06:04 .
drwx------. 31 alex alex 4096 Jul  7 05:39 ..
-rw-rw-r--.  1 alex alex   25 Jul  7 05:39 dummy_file.txt
prw-rw-r--.  1 alex alex    0 Jul  7 05:55 my_pipe
lrwxrwxrwx.  1 alex alex   14 Jul  7 06:04 qwer.txt -> dummy_file.txt
lrwxrwxrwx.  1 alex alex   32 Jul  7 05:39 random_files -> /home/alex/OneDrive/random_files
lrwxrwxrwx.  1 alex alex   33 Jul  7 05:39 random_images -> /home/alex/OneDrive/random_images
lrwxrwxrwx.  1 alex alex   33 Jul  7 05:39 random_videos -> /home/alex/OneDrive/random_videos

Without patch:

Using 'user' Config Dir: /home/alex/.config/onedrive-personal/
Using 'system' Config Dir: 
Configuration file successfully loaded
Initializing the OneDrive API ...
Configuring Global Azure AD Endpoints
Opening the item database ...
All operations will be performed in: /home/alex/OneDrivePersonal
Application version: v2.4.3-6-ge23e063
Account Type: personal
Default Drive ID: 66d53be8a5056eca
Default Root ID: 66D53BE8A5056ECA!101
Remaining Free Space: 5368709070
Fetching details for OneDrive Root
OneDrive Root exists in the database
Initializing the Synchronization Engine ...
Syncing changes from OneDrive ...
Applying changes of Path ID: 66D53BE8A5056ECA!101
Uploading differences of ~/OneDrivePersonal
Processing root
The directory has not changed
Processing random_files
The directory has not changed
Processing random_images
The directory has not changed
Processing random_videos
The directory has not changed
Processing dummy_file.txt
The file has not changed
Processing qwer.txt
The file has not changed
Uploading new items of ~/OneDrivePersonal

[process hangs / infinite wait]

^C

With Patch:

Using 'user' Config Dir: /home/alex/.config/onedrive-personal/
Using 'system' Config Dir: 
Configuration file successfully loaded
Initializing the OneDrive API ...
Configuring Global Azure AD Endpoints
Opening the item database ...
All operations will be performed in: /home/alex/OneDrivePersonal
Application version: v2.4.3-6-ge23e063
Account Type: personal
Default Drive ID: 66d53be8a5056eca
Default Root ID: 66D53BE8A5056ECA!101
Remaining Free Space: 5368709070
Fetching details for OneDrive Root
OneDrive Root exists in the database
Initializing the Synchronization Engine ...
Syncing changes from OneDrive ...
Applying changes of Path ID: 66D53BE8A5056ECA!101
Uploading differences of ~/OneDrivePersonal
Processing root
The directory has not changed
Processing random_files
The directory has not changed
Processing random_images
The directory has not changed
Processing random_videos
The directory has not changed
Processing dummy_file.txt
The file has not changed
Processing qwer.txt
The file has not changed
Uploading new items of ~/OneDrivePersonal
Skipping item './my_pipe' as it is not a valid file
Applying changes of Path ID: 66D53BE8A5056ECA!101

[docsmooth]

clear fix, tested as skipping pipes with the proper error message. I'm also noticing that the version with this fix causes cleaner messaging around bad symlinks, but i don't know if it's this fix.

[abraunegg]

@docsmooth

clear fix, tested as skipping pipes with the proper error message. I'm also noticing that the version with this fix causes cleaner messaging around bad symlinks, but i don't know if it's this fix.

Unsure what version you were previously running as your issue post did not include the client version. #942 fixed issues with symbolic links when they were relative links

[abraunegg]

Updated application output to be consistent:

Uploading new items of ~/OneDrivePersonal
Skipping item - excluded by skip_dir config: ./Dropbox/.dropbox.cache
Skipping item - excluded by skip_dir config: ./Images
Skipping item - excluded by skip_dir config: ./Music
Skipping item - excluded by skip_file config: ./file1.tmp
Skipping item - item is not a valid file: ./my_pipe
Skipping item - invalid symbolic link: ./wertsdeee.txt
Applying changes of Path ID: 66D53BE8A5056ECA!101
Syncing this OneDrive Personal Shared Folder: shared
Applying changes of Path ID: BC7D88EC1F539DCF!1288

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.