-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PEP 770 #230
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Tests will be broken until #229 or #226 goes in. Can we validate the string, perhaps? That would provide a negative example. Specifically, these are in the PEP: [project]
sbom-files = ["..\bom.json"]
[project]
sbom-files = ["bom{.json*"] Edit: this would be fine as a followup, unless we happen to have a validator for this already. We could also put in [project]
name = "example"
version = "1.2.3"
sbom-files ="sboms/bom.cdx.json" as a negative example. IIRC we manually update the changelog before release, so don't think anything is required there. But @abravalheri does releases, so not sure. |
@henryiii Those are good suggestions, if I add a validator for the values I can copy that to I'll add that as a negative example to show we're intentionally not supporting strings. |
Yes, reusing validators is good. ;) I can see if I can make a PR for pyproject-metadata. |
@sethmlarson I don't see Edit: looks like it based on the discussion thread. I think I missed license-files in Dynamic before in pyproject-metadata, as well. Edit 2: Looks like you've listed it here in dynamic, I think that answers my question, at least about PR at pypa/pyproject-metadata#225. |
Closes #228, PEP 770 is nearly provisional. Will update this thread once the PEP is provisional. Because there's no special "negative case" I didn't include an "invalid-examples" test, should I be adding one? Also didn't add an entry to the changelog because it wasn't mentioned in the contributing guide, let me know if I have something to do there too.