Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong join in the Waze parser #519

Closed
koodekraker opened this issue Sep 17, 2024 · 2 comments
Closed

Wrong join in the Waze parser #519

koodekraker opened this issue Sep 17, 2024 · 2 comments

Comments

@koodekraker
Copy link

In the Waze parser, the table RECENTS and PLACES are join, but based on the wrong id.
There is a place_id in the RECENTS table, which should be used to join them together instead of the primary key of the RECENTS table itself.

Scripts/artifacts/waze.py:22

join RECENTS on PLACES.id = RECENTS.id

should be

join RECENTS on PLACES.id = RECENTS.place_id
koodekraker pushed a commit to koodekraker/ALEAPP_fork that referenced this issue Sep 17, 2024
Wrong join in the Waze parser abrignoni#519
0e9e8ca
@koodekraker koodekraker mentioned this issue Sep 17, 2024
Merged
stark4n6 added a commit that referenced this issue Sep 17, 2024
@stark4n6
Merge pull request #520 from koodekraker/bugfix/519-waze-join
2d2d6ba 
Wrong join in the Waze parser #519
@stark4n6
Copy link
Collaborator

Closing thanks to PR

@koodekraker
Copy link
Author

Your're welcome, thanks for the awesome tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stark4n6 @koodekraker