Find crash thread before stacktrace is normalized #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we normalize a stacktrace, we sometimes remove certain frames. The problem is when crash frame is one of those removed frames. In such cases, we simply cannot (reliably) find the crash thread. Therefore, before we normalize the stacktrace, we look for the crash thread and remember its id. We can then use that id later, if needed. Related: rhbz#2168223 Fixes: abrt#337 Signed-off-by: Michal Srb <michal@redhat.com>
Signed-off-by: Michal Srb <michal@redhat.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 63.12% 63.11% -0.01%
==========================================
Files 40 40
Lines 7355 7359 +4
Branches 1233 1235 +2
==========================================
+ Hits 4643 4645 +2
Misses 2180 2180
- Partials 532 534 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@mgrabovsky @michalfabik Anybody for a quick review? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we normalize a stacktrace, we sometimes remove certain
frames. The problem is when crash frame is one of those
removed frames. In such cases, we simply cannot (reliably)
find the crash thread.
Therefore, before we normalize the stacktrace, we look
for the crash thread and remember its id. We can then
use that id later, if needed.
Related: rhbz#2168223
Fixes: #337
Signed-off-by: Michal Srb michal@redhat.com