Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Strings #463

Merged
merged 9 commits into from
Dec 5, 2017
Merged

Block Strings #463

merged 9 commits into from
Dec 5, 2017

Conversation

bruce
Copy link
Contributor

@bruce bruce commented Dec 4, 2017

Supports """-delimited block strings, as defined in graphql/graphql-spec#327, using the implementation in graphql/graphql-js#926 as a reference (omitting SDL description features slated for v1.5).

  • Lexer
  • Parser
    • Base support
    • Escape handling
    • Indentation handling
  • Tests

@bruce
Copy link
Contributor Author

bruce commented Dec 4, 2017

Blurgh, I guess string:split/3 is an Erlang/OTP 20 thing. Going to switch that up for Erlang/OTP 19 compat.

@bruce
Copy link
Contributor Author

bruce commented Dec 4, 2017

(Putting this back as WIP until I can address a warning and a replacement for Erlang/OTP's string:prefix/2.)

@bruce bruce removed the Status:WIP label Dec 5, 2017
@bruce bruce removed the request for review from benwilson512 December 5, 2017 01:11
@bruce bruce merged commit 53c9831 into master Dec 5, 2017
@bruce bruce deleted the feature/block-string branch December 5, 2017 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant