Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is the first step on a bigger journey to get the GraphiQL client(s) up to date.
I might need little guidance here and there since I only started wokring with the codebase this evening, and not everything might be optimal ( looking at you,
build_asset_path/2
)I also have s semi-functional version of graphiql 2.0 behind a new
:beta
interface key, but that one needs some more work to get headers to work, and to figure out whether we still need the @absinthe/absinthe-socketlibs or whether
createGraphiQLFetcher()from
@graphiql/toolkit` can solve whatever prompted the creation of that in the first place out of the box now.If someone has more context/knows, why some decisions were made, that would be greatly appreciated!
This PR
the package still used the 5 year old
graphiql@0.11.10
, which has a bunch of security issues and could benefit from an update in general (bundle size reduction fromreact@16
among others). This PR updates graphiql and introduces a way to have two react versions in the asset list, so graphiql-workspace(the:advanced
interface) stays functional, since it break with newer react versions.Next Steps
The next big step would be to get
graphiql@2
working, especially with headers and subscriptions. The is quite a bit of plumbing going on atm, which I will need to figure out first, plus the newcreateGraphiQLFetcher
function is not shipped in a browser-compatible version, so we might need another intermediary package... 😨Once 2.0 ships and graduates beta stage, we can probably remove/alias the :advanced
interface, since graphiql provides those enhancements out of the box. Also,
graphiql-workspace` hasn't seen an update in ~4 years, so I wouldn't expect and update on that front.Happy about any and all feedback !