Subscription broker #274
Open
Subscription broker #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously subscriptions over HTTP were handled through SSE. This commits adds a callback so the user can choose to handle it differently. It's modelled after how [graphl-ruby](https://graphql-ruby.org/subscriptions/pusher_implementation.html) does it. I think this gives the flexibility to the user to implement their own subscription broker implementation. It gives access to the http request to be changed in a way the user sees fit. There's still some work to be done on the Absinthe side for a user, though this can be done in userland by replacing some phases. `absinthe_phoenix` could use a similar callback. See absinthe-graphql#217 for previous work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously subscriptions over HTTP were handled through SSE.
This commits adds a callback so the user can choose to handle it
differently. It's modelled after how graphl-ruby
does it.
I think this gives the flexibility to the user to implement
their own subscription broker implementation. It gives access to the
http request to be changed in a way the user sees fit.
There's still some work to be done on the Absinthe side for a user,
though this can be done in userland by replacing some phases.
absinthe_phoenixcould use a similar callback.See #217 for
previous work.