-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-888 - Add domians SDK tests #2272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24e9019
to
53ef37c
Compare
arvindh123
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to know why ListDomainUsers
was not covered in Test.
arvindh123
previously approved these changes
Jun 10, 2024
53ef37c
to
6c97cd6
Compare
rodneyosodo
requested changes
Jun 11, 2024
6c97cd6
to
355477c
Compare
355477c
to
5ea6e52
Compare
5ea6e52
to
8cecd24
Compare
990c670
to
8dc9ba5
Compare
arvindh123
previously approved these changes
Jun 26, 2024
8dc9ba5
to
f4b66d9
Compare
f4b66d9
to
4b6ca94
Compare
4b6ca94
to
d621bce
Compare
f54211c
to
a39c3a3
Compare
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
f445cdd
to
ac13a13
Compare
1e3881d
to
518b735
Compare
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
518b735
to
e8c05ac
Compare
dborovcanin
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a featurea because it adds domains SDK tests.
What does this do?
This pr:
pkg/sdk/go/domains_test.go
auth/api/http/domains/requests.go
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, the changes are to the tests.
Did you document any new/modified feature?
No,
Notes