Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-888 - Add domians SDK tests #2272

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a featurea because it adds domains SDK tests.

What does this do?

This pr:

  • Adds domains sdk tests pkg/sdk/go/domains_test.go
  • refactors the validation error returned for empty userIds and relation in auth/api/http/domains/requests.go

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, the changes are to the tests.

Did you document any new/modified feature?

No,

Notes

@felixgateru felixgateru added this to the S5 milestone Jun 6, 2024
@felixgateru felixgateru self-assigned this Jun 6, 2024
@felixgateru felixgateru marked this pull request as ready for review June 9, 2024 21:53
@arvindh123 arvindh123 self-requested a review June 10, 2024 10:12
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to know why ListDomainUsers was not covered in Test.

pkg/sdk/go/domains.go Show resolved Hide resolved
arvindh123
arvindh123 previously approved these changes Jun 10, 2024
pkg/sdk/go/domains_test.go Show resolved Hide resolved
pkg/sdk/go/domains.go Show resolved Hide resolved
pkg/sdk/go/domains.go Outdated Show resolved Hide resolved
arvindh123
arvindh123 previously approved these changes Jun 26, 2024
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@felixgateru felixgateru force-pushed the mg888-domains branch 2 times, most recently from f445cdd to ac13a13 Compare July 3, 2024 13:07
@felixgateru felixgateru force-pushed the mg888-domains branch 3 times, most recently from 1e3881d to 518b735 Compare July 3, 2024 13:26
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@dborovcanin dborovcanin merged commit 9d982c4 into absmach:main Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants