rename webpack.full/quick to webpack.production/development

absolvent · Apr 13, 2015 · a4a8724 · a4a8724
1 parent 650b54c
commit a4a8724
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/gore-gulp/__tests__/setup/setup.test.js b/gore-gulp/__tests__/setup/setup.test.js
@@ -42,10 +42,10 @@ describe("setup", function () {
     });
 
     it("sets up gulp instance using development settings", function () {
-        doTestSetup("development", "webpack.quick");
+        doTestSetup("development", "webpack.development");
     });
 
     it("sets up gulp instance using production settings", function () {
-        doTestSetup("production", "webpack.full");
+        doTestSetup("production", "webpack.production");
     });
 });
diff --git a/gore-gulp/__tests__/webpack/full.test.js b/gore-gulp/__tests__/webpack/full.test.js
@@ -48,7 +48,7 @@ describe("webpack", function () {
 
         return gg(baseDir)
             .webpack
-            .full(gulp, function (pckg) {
+            .production(gulp, function (pckg) {
                 distDir = path.join(tmpDir, pckg.directories.dist);
 
                 return _.merge(pckg, {

diff --git a/gore-gulp/index.js b/gore-gulp/index.js
@@ -18,9 +18,9 @@ function setup(options, pckgPromise, gulp, self) {
     var defaultWebpackVariant;
 
     if ("production" === process.env.NODE_ENV) {
-        defaultWebpackVariant = "webpack.full";
+        defaultWebpackVariant = "webpack.production";
     } else {
-        defaultWebpackVariant = "webpack.quick";
+        defaultWebpackVariant = "webpack.development";
     }
 
     gulp.task("default", [
@@ -33,8 +33,8 @@ function setup(options, pckgPromise, gulp, self) {
     gulp.task("webpack", [
       defaultWebpackVariant
     ]);
-    gulp.task("webpack.full", self.webpack.full());
-    gulp.task("webpack.quick", self.webpack.quick());
+    gulp.task("webpack.development", self.webpack.development());
+    gulp.task("webpack.production", self.webpack.production());
 }
 
 function setupTask(baseDir, pckgPromise, task) {
@@ -62,8 +62,8 @@ module.exports = function (baseDir) {
         },
         "test": setupTask(baseDir, pckgPromise, test),
         "webpack": {
-            "full": setupTask(baseDir, pckgPromise, webpack.full),
-            "quick": setupTask(baseDir, pckgPromise, webpack.quick)
+            "development": setupTask(baseDir, pckgPromise, webpack.development),
+            "production": setupTask(baseDir, pckgPromise, webpack.production)
         }
     };
 };

diff --git a/gore-gulp/webpack.js b/gore-gulp/webpack.js
@@ -17,12 +17,11 @@ var path = require("path"),
     slug = require("slug"),
     webpack = require("webpack");
 
-function full(config) {
+function development(config) {
     return _.assign(config, {
-        "debug": false,
+        "debug": true,
         "plugins": [
-            new webpack.optimize.CommonsChunkPlugin(config.pckg.name + ".common.min.js"),
-            new webpack.optimize.UglifyJsPlugin()
+            new webpack.optimize.CommonsChunkPlugin(config.pckg.name + ".common.min.js")
         ]
     });
 }
@@ -66,11 +65,12 @@ function normalizeEntry(baseDir, pckg, entry, fileExtensions) {
     return entry;
 }
 
-function quick(config) {
+function production(config) {
     return _.assign(config, {
-        "debug": true,
+        "debug": false,
         "plugins": [
-            new webpack.optimize.CommonsChunkPlugin(config.pckg.name + ".common.min.js")
+            new webpack.optimize.CommonsChunkPlugin(config.pckg.name + ".common.min.js"),
+            new webpack.optimize.UglifyJsPlugin()
         ]
     });
 }
@@ -148,14 +148,14 @@ function stub(baseDir, pckgPromise) {
 }
 
 module.exports = {
-    "full": function (baseDir, pckgPromise) {
+    "development": function (baseDir, pckgPromise) {
         return function () {
-            return stub(baseDir, pckgPromise).then(full).then(run);
+            return stub(baseDir, pckgPromise).then(development).then(run);
         };
     },
-    "quick": function (baseDir, pckgPromise) {
+    "production": function (baseDir, pckgPromise) {
         return function () {
-            return stub(baseDir, pckgPromise).then(quick).then(run);
+            return stub(baseDir, pckgPromise).then(production).then(run);
         };
     }
 };