Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single header with source code file #455

Merged
merged 15 commits into from
Jan 11, 2017
Merged

Conversation

easylogging
Copy link
Contributor

No description provided.

abumq and others added 8 commits January 3, 2017 17:55
- Non-templated, non-trivial or non-performance critical code is all in a separate source file.
- Replaced ELPP_STACKTRACE_ON_CRASH (which wasn’t used) with ELPP_FEATURE_CRASH_LOG.
- Small fixes for compiler warnings.
Separate source/header files, bug fixes…
@easylogging easylogging merged commit 663d421 into develop Jan 11, 2017
@easylogging easylogging deleted the elpp_single_header_changes branch January 11, 2017 05:29
@aparajita
Copy link
Contributor

Something that I didn't point out before: it turns out I didn't need a separate FormatSpecifierValueResolver typedef. The only change existing users need to make is to wrap plain functions (not part of a class/struct) with std::bind in the CustomFormatSpecifier constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants