[BAD] Automatic PR for 1ca36ea7-5c3b-4d9b-80f1-4180c6781e07 #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR was created automatically by CodeNarrator. The following issues were fixed:
BLD: improvements to meson.build files (pandas-dev#54949)
pure: false
only in a single place. This is recommended forrobustness, this way you can't forget it in a subdirectory and end up
with a subtly broken package only on niche Linux distros that split
purelib and platlib directories.
py.install_sources
with a list input rather than in a foreachloop.
werror
comment: it's never a good idea to enable-Werror
by default in the build config of a library, that can easilybreak builds. This should be done in one or more CI jobs instead.
generate_version.py
with a shebang, not 'python'The way this was before can result in build failures. It assumed that
python
is a working Python 3.x interpreter, and that is not alwaystrue. See for example this bug report for the exact same thing in
NumPy, where
python
isn't working for Sage:numpy/numpy#24514
Meson guarantees that .py scripts with a shebang on the top line will
be run with a Python interpreter (if there's none on the PATH, it can
use the one Meson itself is run with). Hence this is the most robust
way of using
run_command
on a .py script.Corresponding commit hash: 3334832