This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Fix a typo in API.md #281
Merged
Fix a typo in API.md #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istarkov
reviewed
Nov 28, 2016
| @@ -749,7 +749,7 @@ setObservableConfig<Stream>({ | |||
| Observables in Recompose are plain objects that conform to the [ES Observable proposal](https://github.com/zenparsing/es-observable). Usually, you'll want to use them alongside an observable library like RxJS so that you have access to its suite of operators. By default, this requires you to convert the observables provided by Recompose before applying any transforms: | |||
|
|
|||
| ```js | |||
| mapPropsStream($props => { | |||
| mapPropsStream(props$ => { | |||
| const $rxjsProps = Rx.Observable.from(props$) | |||
| // ...now you can use map, filter, scan, etc. | |||
| return $transformedProps | |||
There was a problem hiding this comment.
The same ;-) could you also please
istarkov
reviewed
Nov 28, 2016
| @@ -749,7 +749,7 @@ setObservableConfig<Stream>({ | |||
| Observables in Recompose are plain objects that conform to the [ES Observable proposal](https://github.com/zenparsing/es-observable). Usually, you'll want to use them alongside an observable library like RxJS so that you have access to its suite of operators. By default, this requires you to convert the observables provided by Recompose before applying any transforms: | |||
|
|
|||
| ```js | |||
| mapPropsStream($props => { | |||
| mapPropsStream(props$ => { | |||
| const $rxjsProps = Rx.Observable.from(props$) | |||
There was a problem hiding this comment.
And the same for rxjsProps
There was a problem hiding this comment.
Right, I can fix it.
istarkov
reviewed
Nov 28, 2016
| mapPropsStream($props => { | ||
| const $rxjsProps = Rx.Observable.from(props$) | ||
| mapPropsStream(props$ => { | ||
| const rxjsProps$ = Rx.Observable.from(props$) | ||
| // ...now you can use map, filter, scan, etc. | ||
| return $transformedProps |
There was a problem hiding this comment.
The same for transformedProps as we use Finnish notation ;-)
|
Thank you! It's hard to see such typos. |
|
Thank you for having me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.