This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
New lifecycles support #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
next steps
|
neighborhood999
added a commit
to neighborhood999/recompose
that referenced
this pull request
Apr 22, 2018
* Add CHANGELOG.md * add lifecycle example in docs * filter packages by the existence of a package.json file (acdlite#575) * use static class properties to convert toClass implicit return arrow * Adding an optional callback argument to the `dispatch` method provided by `withReducer` * Fix babel-plugin-lodash name on readme (acdlite#606) * Add a debugging section in README * Fix a typo in README * Update docs & readme * babel-preset-es2015 -> babel-preset-env * change rest element to be the last in restructuring * Pass blacklist argument to hoist-non-react-statics using hoistStatics * Add blacklist docs for hoistStatics (acdlite#635) * Refactor rollup config (acdlite#645) - move all bundles into dist folder - add size snapshot - remove treeshake test * Update dependencies before changes according to React 16.3+ (acdlite#646) * New lifecycles support (acdlite#647) * Remove cache from withHandlers * Update createSink * Update withPropsOnChange * remove memoize as useless * Simplify code * Include flow types into library (acdlite#649) * Fix types for modern flow * Move flow declarations and test into recompose * Fix docs * Remove errors * Add yarn-error to gitignore * Append flow 2 test * Update release to support flow types * Remove unneeded command * recompose v0.27.0 * chore: update yarn.lock * chore: update yarn.lock * fix: fix scripts * fix: remove flow command in test
This was referenced Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In async mode
propsMapperinwithPropsOnChangecan be called multiple timesit can be avoided using memoize see this commit 83fc7ca
but it does not solve some edge cases as memoize will work on all
propsso multiple calls will still be possible. So I think to remove it.