This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Add withRenderProps #663
Merged
Add withRenderProps #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super! Thank you, I will check at sunday|monday, seems like travis is broken now. |
|
Is TravisCI broken now? |
|
see log: command "eval yarn " failed |
|
Thanks, Ill add flowtypings and make release. |
|
Like it!! It's great |
|
What are the use cases and benefits of withRenderProps? I asked this question on SO but did not get any answer. I understand the render prop pattern. What I'd like to know is when/why I would convert some of recompose's HOCs (or my own HOCs) this way, using withRenderProps. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this tweet. Let me know if there's anything missing.