Permit react 17 #821

cesine · 2020-11-24T01:30:15Z

How this was tested

$ yarn install
$ yarn run lint
yarn run v1.19.1
$ eslint scripts src

~/recompose/src/packages/recompose/__tests__/setPropTypes-test.js
  9:23  warning  Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

~/recompose/src/packages/recompose/__tests__/setStatic-test.js
  11:23  warning  Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

~/recompose/src/packages/recompose/__tests__/toClass-test.js
  29:24  warning  Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

~/recompose/src/packages/recompose/onlyUpdateForPropTypes.js
  7:35  warning  Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

~/recompose/src/packages/recompose/toClass.js
  10:42  warning  Using propTypes from another component is not safe because they may be removed in production builds  react/forbid-foreign-prop-types

✖ 5 problems (0 errors, 5 warnings)

(node:26095) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-config-airbnb-base/index.js")
✨  Done in 3.32s.


$ yarn test
yarn run v1.19.1
$ jest && flow check && cross-env SNAPSHOT=match npm run build:recompose

 RUNS  src/packages/recompose/__tests__/withStateHandlers-test.js
 RUNS  src/packages/recompose/__tests__/withPropsOnChange-test.js
 RUNS  src/packages/recompose/__tests__/withHandlers-test.js
 RUNS  src/packages/recompose/__tests__/componentFromStream-test.js
 RUNS  src/packages/recompose/__tests__/withReducer-test.js
 RUNS  src/packages/recompose/__tests__/fromRenderProps-test.js
 RUNS  src/packages/recompose/__tests__/toClass-test.js
 RUNS  src/packages/recompose/__tests__/withState-test.js
 RUNS  src/packages/recompose/__tests__/setObservableConfig-test.js
 RUNS  src/packages/recompose/__tests__/branch-test.js
 PASS  src/packages/recompose/__tests__/componentFromStream-test.js.js
 PASS  src/packages/recompose/__tests__/setObservableConfig-test.js (5.155s)
 PASS  src/packages/recompose/__tests__/withPropsOnChange-test.js (7.928s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withStateHandlers-test.js (7.971s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/shallowEqual-test.js
 PASS  src/packages/recompose/__tests__/branch-test.js (7.965s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withContext-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withState-test.js (8.038s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withHandlers-test.js (8.16s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withReducer-test.js (8.082s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/toClass-test.js (8.174s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/fromRenderProps-test.js (8.128s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/onlyUpdateForPropTypes-test.js (8.302s)
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/shouldUpdate-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/withProps-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/defaultProps-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/pure-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/createEventHandler-test.js
 PASS  src/packages/recompose/__tests__/hoistStatics-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/onlyUpdateForKeys-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/getDisplayName-test.js
 PASS  src/packages/recompose/__tests__/flattenProp-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/compose-test.js
 PASS  src/packages/recompose/__tests__/createSink-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/mapProps-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/isClassComponent-test.js
 PASS  src/packages/recompose/__tests__/mapPropsStream-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/renderComponent-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/nest-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/toRenderProps-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/renameProps-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/componentFromProp-test.js
 PASS  src/packages/recompose/__tests__/lifecycle-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/renameProp-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/renderNothing-test.js
 PASS  src/packages/recompose/__tests__/setPropTypes-test.js
 PASS  src/packages/recompose/__tests__/wrapDisplayName-test.js
 PASS  src/packages/recompose/__tests__/setStatic-test.js
 PASS  src/packages/recompose/__tests__/setDisplayName-test.js
 PASS  src/packages/recompose/__tests__/getContext-test.js
 PASS  src/packages/recompose/__tests__/mapPropsStreamWithConfig-test.js
  ● Console

    console.warn node_modules/react/cjs/react.development.js:220
      Warning: React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.

 PASS  src/packages/recompose/__tests__/componentFromStreamWithConfig-test.js

Test Suites: 42 passed, 42 total
Tests:       97 passed, 97 total
Snapshots:   0 total
Time:        11.033s
Ran all test suites.
Found 0 errors
npm WARN lifecycle The node binary used for scripts is /var/folders/z5/pq552q7d5hz7_m1887s3v_z80000gp/T/yarn--1606181196241-0.7648074009398107/node but npm is using node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> recompose-build@ build:recompose ~/recompose
> cross-env PACKAGE_NAME=recompose rollup --config scripts/rollup.config.js


./src/packages/recompose/index.js → lib/packages/recompose/dist/Recompose.umd.js...
Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade caniuse-lite browserslist`
created lib/packages/recompose/dist/Recompose.umd.js in 1.3s

./src/packages/recompose/index.js → lib/packages/recompose/dist/Recompose.min.js...
created lib/packages/recompose/dist/Recompose.min.js in 946ms

./src/packages/recompose/index.js → lib/packages/recompose/dist/Recompose.cjs.js...
created lib/packages/recompose/dist/Recompose.cjs.js in 298ms

./src/packages/recompose/index.js → lib/packages/recompose/dist/Recompose.esm.js...
created lib/packages/recompose/dist/Recompose.esm.js in 1s
✨  Done in 22.45s.

joealden · 2020-11-25T12:45:37Z

package.json

-    "react": "^16.3.1",
+    "react": "^17.0.1",


It's likely not wise to bump this so that anything between 16.3.1 and 17.0.1 isn't allowed.

@joealden thanks for the review, the tests are passing. Why do you think it would be risky to bump to the current react version for development of this package?

joealden · 2020-11-25T12:45:44Z

types/flow-example/package.json

-    "react": "^15.6.1",
+    "react": "^17.0.1",


It's likely not wise to bump this so that anything between 16.3.1 and 17.0.1 isn't allowed.

G-Rath · 2021-04-25T04:52:27Z

This'd fix #827 - as I said on that issue:

This is a blocker with npm@7 now, as it installs peer dependencies by default so any project using react@17 won't be able to use recompose (nor any library using it, such as @nivo) without using --legacy-peer-deps.

Would be great if this PR could be merged & a new release made :)

mcmxcdev · 2021-08-11T07:10:37Z

Any update on this?

ruzpuz · 2021-11-10T15:55:01Z

uhm... hey guys, can this be merged? It is passing all checks after all...

permit react 17

1ecb6d9

cesine marked this pull request as ready for review November 24, 2020 03:27

joealden reviewed Nov 25, 2020

View reviewed changes

brodycj mentioned this pull request Mar 12, 2021

initial release - react-recompose react-recompose/react-recompose#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permit react 17 #821

Permit react 17 #821

cesine commented Nov 24, 2020

joealden Nov 25, 2020

cesine Dec 21, 2020

joealden Nov 25, 2020

G-Rath commented Apr 25, 2021

mcmxcdev commented Aug 11, 2021

ruzpuz commented Nov 10, 2021

Permit react 17 #821

Are you sure you want to change the base?

Permit react 17 #821

Conversation

cesine commented Nov 24, 2020

joealden Nov 25, 2020

Choose a reason for hiding this comment

cesine Dec 21, 2020

Choose a reason for hiding this comment

joealden Nov 25, 2020

Choose a reason for hiding this comment

G-Rath commented Apr 25, 2021

mcmxcdev commented Aug 11, 2021

ruzpuz commented Nov 10, 2021