Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Safari doesn't display hostname but Chrome does. #104

Closed
pyrodex opened this issue Aug 31, 2024 · 4 comments
Closed

[BUG] Safari doesn't display hostname but Chrome does. #104

pyrodex opened this issue Aug 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@pyrodex
Copy link

pyrodex commented Aug 31, 2024

I noticed in Safari the hostnames aren't showing but they are in Chrome.

Chrome:
Screenshot 2024-08-31 at 6 16 31 PM
Safari:
Screenshot 2024-08-31 at 6 16 40 PM

@SteveClement
Copy link
Contributor

I can confirm the Bug.

The reason is that the tag wants to be inside a Tag. Maybe @aceberg could tell us why this should be an option list in the first place. Perhaps if you want to have multiple names for one host. A PR has been done which would fix this #110

@aceberg
Copy link
Owner

aceberg commented Sep 1, 2024

I can confirm the Bug.

The reason is that the tag wants to be inside a Tag. Maybe @aceberg could tell us why this should be an option list in the first place. Perhaps if you want to have multiple names for one host. A PR has been done which would fix this #110

Using option was intended. I needed a tag that has value field inside.
May be, you can suggest something better than option?

@aceberg aceberg added the bug Something isn't working label Sep 1, 2024
@SteveClement
Copy link
Contributor

SteveClement commented Sep 2, 2024

Using option was intended. I needed a tag that has value field inside. May be, you can suggest something better than option?

I asked chatgpt and got this suggestion:

<data id="name2" value="my-amazing-server.my.tld.">my-amazing-server.my.tld.</data>

I tried it in a developer window by changing the HTML, and it seems to work.

@aceberg I amended my PR #110 perhaps you could test if it works as expected.

@aceberg
Copy link
Owner

aceberg commented Sep 2, 2024

Using option was intended. I needed a tag that has value field inside. May be, you can suggest something better than option?

I asked chatgpt and got this suggestion:

<data id="name2" value="my-amazing-server.my.tld.">my-amazing-server.my.tld.</data>

I tried it in a developer window by changing the HTML, and it seems to work.

@aceberg I amended my PR #110 perhaps you could test if it works as expected.

Yes, it works! Thanks! Will be included in the release in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants