-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter should exit out of AceJump when there is only one result on screen #274
Comments
Second this. Doesn't make much sense to press any additional keys if result has already been found. |
Now that I'm thinking of this, should you even have to press Enter if there is one match? |
If the caret jumps when there is only one match, the user can be confused as to where the caret went. It can also cause a race condition in the brain if it keeps flushing to the keyboard after the caret has jumped, meaning the user will enter text by mistake! I'm sure there are ways to do it such as waiting a delay after stopping typing and using visual effects to direct the eyes, but I'm not sure it's worth the effort. |
Yes, we experimented with a similar feature a while back and received some negative feedback. While it is possible to consider such optimizations, in practice, it's better to have the user explicitly control the selection mechanism. Also, search mode has state transitions to other modes (e.g. via Tab or Backspace) that would be broken if we prematurely selected a solitary visible tag. So we will keep the Enter/Shift+Enter selection mechanism, even when there is a single tag. |
Currently you have to press Enter then Escape due to the new feature for jumping between several markers with enters.
The text was updated successfully, but these errors were encountered: