Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ace_frag #824

Closed
5 of 7 tasks
nicolasbadano opened this issue Apr 23, 2015 · 2 comments · Fixed by #874
Closed
5 of 7 tasks

Clean up ace_frag #824

nicolasbadano opened this issue Apr 23, 2015 · 2 comments · Fixed by #874
Assignees
@ulteq
Labels
kind/task
Milestone
3.0.0

Comments

@nicolasbadano
Copy link
Contributor

  • Add headers for functions
  • Some function calls have the nou_ prefix; those are surely not working right atm (but it's probably debug stuff)
  • Replace player by ACE_player on various places
  • Remove obsolete functions (e.g., fnc_vectorDiffFast)
  • Replace some vector functions (e.g., BIS_fnc_magnitude)
  • Use ACE_Settings to enable/disable frags
  • Probably add some comments to functions
@nicolasbadano nicolasbadano changed the title Cleanup ace_frag Clean up ace_frag Apr 23, 2015
@KoffeinFlummi KoffeinFlummi added this to the 3.0.0 milestone Apr 23, 2015
@thojkooi
Copy link
Contributor

A lot of this is already done in #784

@nicolasbadano
Copy link
Contributor Author

A lot of this is already done in #784

Excellent, even better! tbh I missed that PR

@ulteq ulteq self-assigned this Apr 26, 2015
@ulteq ulteq mentioned this issue Apr 26, 2015
Merged
@ulteq ulteq closed this as completed Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulteq ulteq

Labels
kind/task
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Frag cleanup acemod/ACE3
4 participants
@KoffeinFlummi @thojkooi @nicolasbadano @ulteq