Frag cleanup #874
Frag cleanup #874
Conversation
*Moved GVAR(enabled) into ACE_Settings.hpp *Replaced BIS_fnc_magnitude with vectorMagnitude *Renamed Nou_GBU12 *Added G_40mm_HE config data
|
We should also disable the firedEH if the projectile does not inherit from GrenadeBase. |
|
Why would we disable the firedEH for that? Tons of other things that cause frag inherit from stuff other than GrenadeBase.... |
| #include "script_component.hpp" | ||
| private ["_round"]; | ||
| _round = _this select 0; | ||
| GVAR(blackList) set[(count GVAR(blackList)), _round]; |
There was a problem hiding this comment.
Are we removing the blacklist? This function might actually be useful to keep around. Though we do need to adjust it to a pushback.
Makes sense.
No, the blacklist is still in place, but the addBlackList function was never called, so I removed it for now. |
|
But we could use it for access by third parties. That way we do not have to expose the variable, but only the function. ref: #820 |
|
Agreed: 3c92cab |
* Added missing privates * Removed unused privates * Replaced some old vector calculations with new vector commands
|
@NouberNou, can we merge it? |
|
Lets do #342 in this branch too first, and then merge. |
|
Ok |
|
By just simply looking I assume GBU12 will spawn loads of shrapnels? Will it impact framerate? |
|
Well you shouldn't be dropping 50 GBU's all at the same time, so no :p |
Those are done:
|
|
I will merge this tomorrow, if there are no objections. |
Fixes: #824
Review needed.