Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frag - Add Submunition Fragmentation #10209

Closed
wants to merge 356 commits into from

Conversation

lambdatiger
Copy link
Contributor

This PR is based on PR #10157 and requires it to be merged. This may need to be changed once #10163 is merged.

When merged this pull request will:

  • Makes the function shouldFrag check whether a projectile's submunitions would frag and adds relevant event handlers if they would.
    • Currently no explicit recursion checks because Arma should fail to with recursive self-referential submunitions.
  • Adds child function to initialize fragmentation to be called by both fired and submunition spawned event handler.

As always, feedback desired.

TODO

  • Double check that Arma 3 does not accept self-referential submunition loops.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

lambdatiger and others added 30 commits January 15, 2024 14:09
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
quick testing shows a whole 600ns increase in

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
…shooters

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@lambdatiger
Copy link
Contributor Author

Should be more adequately resolved by switching to using event system introduced with #10243.

@lambdatiger lambdatiger closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants