Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flashsupressor to asdg_MuzzleSlot_338 #3345

Merged
merged 3 commits into from
Feb 21, 2016
Merged

Add flashsupressor to asdg_MuzzleSlot_338 #3345

merged 3 commits into from
Feb 21, 2016

Conversation

PabstMirror
Copy link
Contributor

When merged this pull request will:

Fix #3344 ?

I don't really know the JR stuff that well, but this seems to fix.
Should we switch other things to use the compatibleItems class instead of array?

@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** needs review labels Feb 19, 2016
@nicolasbadano
Copy link
Contributor

Do the other suppressor work, or should we do the same for all cases?

@nicolasbadano nicolasbadano added this to the 3.5.0 milestone Feb 19, 2016
@PabstMirror
Copy link
Contributor Author

Yeah, other DMRs are effected as well. But I'm not sure I really understand the JR configs.

Most guns have something like this:


class asdg_MuzzleSlot_762: asdg_MuzzleSlot { // for 7.62x39 suppressors
    class compatibleItems {
        ACE_muzzle_mzls_B = 1;
    };
};

Which make adding muzzle attachments clean, But the 6.5mm (like the MX) don't seem to use that?

@bux
Copy link
Member

bux commented Feb 19, 2016

tagging @robalo

@robalo
Copy link

robalo commented Feb 19, 2016

Looks good to me. Here's how the slot is configured in CBA for vanilla attachments:
https://github.com/CBATeam/CBA_A3/blob/master/addons/jr/jr_classes.hpp#L141
And here's where the JR weapon slot is assigned to the weapon:
https://github.com/CBATeam/CBA_A3/blob/master/addons/jr/cfgweapons.hpp#L81

For MX there's an open issue CBATeam/CBA_A3#252

commy2 added a commit that referenced this pull request Feb 21, 2016
Add flashsupressor to asdg_MuzzleSlot_338
@commy2 commy2 merged commit f4a985f into master Feb 21, 2016
@commy2 commy2 deleted the jrCompat338 branch February 21, 2016 22:46
@commy2
Copy link
Contributor

commy2 commented Feb 21, 2016

👍 works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.338 BadNews Lapua , Noreen Muzzle Attatchments (FlashSuppressor does not attatch)
5 participants