Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSN hash #4089

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Improve SSN hash #4089

merged 1 commit into from
Jul 15, 2016

Conversation

PabstMirror
Copy link
Contributor

Passes @bux578 's splendid test code: https://codeshare.io/jorDJ

Uses all chars of long names, and remixes input so that "A" does not always turn into 5

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 12, 2016
@PabstMirror PabstMirror added this to the 3.7.0 milestone Jul 12, 2016
@bux
Copy link
Member

bux commented Jul 12, 2016

☺️

@jonpas
Copy link
Member

jonpas commented Jul 12, 2016

3.6.2?

@nicolasbadano
Copy link
Contributor

Yay! @bux578 , nice list of names

3.6.2?

Nah, there's really no need to redo this PR.

@thojkooi
Copy link
Contributor

This is for dog tags, which is not in the current release but in 3.7.0.

@jonpas
Copy link
Member

jonpas commented Jul 12, 2016

Oh right 👊 (there is no picard emoji).

@kymckay
Copy link
Member

kymckay commented Jul 15, 2016

Very elegant 👍 An easy decision to merge!

@kymckay kymckay merged commit fed71b0 into master Jul 15, 2016
@kymckay kymckay deleted the dogtagSSN branch July 15, 2016 21:59
@bux
Copy link
Member

bux commented Jul 16, 2016

So, one could say this was the first test driven development we did? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants