Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ACE hash functions in favor of CBA versions #4171

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 26, 2016

When merged this pull request will:

e.g.:
-#define HANDLECATCH diag_log text _exception; assert(exception=="")

exception is undefined. Probably meant _exception. These conflict with our ACE_LOGX macros

@commy2 commy2 added the kind/cleanup Release Notes: **CHANGED:** label Jul 26, 2016
@commy2 commy2 added this to the 3.7.0 milestone Jul 26, 2016
@commy2 commy2 self-assigned this Jul 26, 2016
@PabstMirror
Copy link
Contributor

[] call CBA_fnc_hashCreate = ["#CBA_HASH#",[],[],any]
[] call ACE_common_fnc_hashCreate = [[],[]]

We do some manual iteration through the old hashes with stuff like
} count (GVAR(syncedEvents) select 0);
which breaks with the changed functions.

I think our best bet is to switch our stuff to use CBA hashes and leave ace's hash functions alone but mark as deprecated.

@commy2
Copy link
Contributor Author

commy2 commented Jul 30, 2016

component that have to be converted to CBA hashes:

  • syncedEvents
  • laser
  • map_gestures
  • finger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants